M3: Reorder + Inspiration – Schritt 1 (Logik): Reorder-UseCase, Inspiration-Query (ADR-006), Adopt-UseCase + Unit-Tests

2026-09-19 15:57:13 +02:00
parent ce77785003
commit 52a34225fa
11 changed files with 686 additions and 0 deletions
@@ -0,0 +1,146 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Tests\Unit\Logic\Essen\Query;
+
+use App\Logic\Common\ClockInterface;
+use App\Logic\Essen\Manager\MahlzeitManagerInterface;
+use App\Logic\Essen\Model\Mahlzeit;
+use App\Logic\Essen\Model\MahlzeitStatus;
+use App\Logic\Essen\Model\Wochentag;
+use App\Logic\Essen\Query\MahlzeitInspirationQuery;
+use PHPUnit\Framework\TestCase;
+
+final class MahlzeitInspirationQueryTest extends TestCase
+{
+    private \DateTimeImmutable $jetzt;
+
+    protected function setUp(): void
+    {
+        $this->jetzt = new \DateTimeImmutable('2026-09-18 00:00:00');
+    }
+
+    private function clock(): ClockInterface
+    {
+        $clock = $this->createStub(ClockInterface::class);
+        $clock->method('now')->willReturn($this->jetzt);
+        return $clock;
+    }
+
+    /** @param list<Mahlzeit> $mahlzeiten */
+    private function manager(array $mahlzeiten): MahlzeitManagerInterface
+    {
+        $manager = $this->createMock(MahlzeitManagerInterface::class);
+        $manager->expects(self::once())->method('list')->with(null)->willReturn($mahlzeiten);
+        return $manager;
+    }
+
+    private function gegessen(int $id, string $name, \DateTimeImmutable $gegessenAm): Mahlzeit
+    {
+        return new Mahlzeit($id, $name, '', [Wochentag::Mo], 1, MahlzeitStatus::Gegessen, $this->jetzt, $this->jetzt, $gegessenAm);
+    }
+
+    private function geplant(int $id, string $name): Mahlzeit
+    {
+        return new Mahlzeit($id, $name, '', [Wochentag::Mo], 1, MahlzeitStatus::Geplant, $this->jetzt, $this->jetzt, null);
+    }
+
+    public function testExecuteLeereListeLiefertKeineVorschlaege(): void
+    {
+        $query = new MahlzeitInspirationQuery($this->manager([]), $this->clock());
+
+        self::assertSame([], $query->execute());
+    }
+
+    public function testExecuteOhneArchivEintraegeKeineVorschlaege(): void
+    {
+        // Nur `geplant` – kein Gericht im Archiv.
+        $query = new MahlzeitInspirationQuery($this->manager([
+            $this->geplant(1, 'Bolognese'),
+            $this->geplant(2, 'Curry'),
+        ]), $this->clock());
+
+        self::assertSame([], $query->execute());
+    }
+
+    public function testExecuteSortiertAbsteigendNachScoreUndWaehltRepraesentanten(): void
+    {
+        // "Bolognese": gegessen vor 10 Tagen (id 1) + 1 geplanter Eintrag → auftraete 2,
+        //   repraesentant = id 1.
+        // "Curry": gegessen vor 3 Tagen (id 3), auftraete 1.
+        $query = new MahlzeitInspirationQuery($this->manager([
+            $this->gegessen(1, 'Bolognese', new \DateTimeImmutable('2026-09-08 00:00:00')),
+            $this->geplant(2, 'Bolognese'),
+            $this->gegessen(3, 'Curry', new \DateTimeImmutable('2026-09-15 00:00:00')),
+        ]), $this->clock());
+
+        $vorschlaege = $query->execute();
+
+        self::assertCount(2, $vorschlaege);
+        self::assertSame(1, $vorschlaege[0]->id);
+        self::assertSame('Bolognese', $vorschlaege[0]->name);
+        self::assertSame(2, $vorschlaege[0]->auftraete);
+        self::assertSame(3, $vorschlaege[1]->id);
+        self::assertSame('Curry', $vorschlaege[1]->name);
+        self::assertSame(1, $vorschlaege[1]->auftraete);
+        // Staleness dominiert: das länger nicht gekochte Gericht hat den höheren Score.
+        self::assertGreaterThan($vorschlaege[1]->score, $vorschlaege[0]->score);
+    }
+
+    public function testExecuteWaehltNeuestenGegessenenEintragAlsRepraesentanten(): void
+    {
+        $query = new MahlzeitInspirationQuery($this->manager([
+            $this->gegessen(1, 'Bolognese', new \DateTimeImmutable('2026-09-01 00:00:00')),
+            $this->gegessen(4, 'Bolognese', new \DateTimeImmutable('2026-09-08 00:00:00')),
+        ]), $this->clock());
+
+        $vorschlaege = $query->execute();
+
+        self::assertCount(1, $vorschlaege);
+        self::assertSame(4, $vorschlaege[0]->id);
+        self::assertEquals(new \DateTimeImmutable('2026-09-08 00:00:00'), $vorschlaege[0]->gegessenAm);
+        self::assertSame(2, $vorschlaege[0]->auftraete);
+    }
+
+    public function testExecuteAusschlussSpruengtBereitsVorgeschlageneGerichte(): void
+    {
+        $query = new MahlzeitInspirationQuery($this->manager([
+            $this->gegessen(1, 'Bolognese', new \DateTimeImmutable('2026-09-08 00:00:00')),
+            $this->gegessen(3, 'Curry', new \DateTimeImmutable('2026-09-15 00:00:00')),
+        ]), $this->clock());
+
+        // "Weitere 5": Bolognese (id 1) wurde bereits vorgeschlagen.
+        $vorschlaege = $query->execute(5, [1]);
+
+        self::assertCount(1, $vorschlaege);
+        self::assertSame('Curry', $vorschlaege[0]->name);
+    }
+
+    public function testExecuteBemaessErgebnisAnLimit(): void
+    {
+        $query = new MahlzeitInspirationQuery($this->manager([
+            $this->gegessen(1, 'Bolognese', new \DateTimeImmutable('2026-09-08 00:00:00')),
+            $this->gegessen(2, 'Curry', new \DateTimeImmutable('2026-09-12 00:00:00')),
+            $this->gegessen(3, 'Pasta', new \DateTimeImmutable('2026-09-15 00:00:00')),
+        ]), $this->clock());
+
+        $vorschlaege = $query->execute(2);
+
+        self::assertCount(2, $vorschlaege);
+        self::assertSame(['Bolognese', 'Curry'], array_map(static fn ($v) => $v->name, $vorschlaege));
+    }
+
+    public function testExecuteGleichstandEntscheidetAlphabetisch(): void
+    {
+        // Beide Gerichte: gleiche Pause, gleiche Auftritte → Score-Gleichstand.
+        $query = new MahlzeitInspirationQuery($this->manager([
+            $this->gegessen(1, 'Zwiebelsuppe', new \DateTimeImmutable('2026-09-13 00:00:00')),
+            $this->gegessen(2, 'Apfelkuchen', new \DateTimeImmutable('2026-09-13 00:00:00')),
+        ]), $this->clock());
+
+        $vorschlaege = $query->execute();
+
+        self::assertSame(['Apfelkuchen', 'Zwiebelsuppe'], array_map(static fn ($v) => $v->name, $vorschlaege));
+    }
+}
@@ -0,0 +1,90 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Tests\Unit\Logic\Essen\UseCase;
+
+use App\Logic\Common\ClockInterface;
+use App\Logic\Common\EventDispatcherInterface;
+use App\Logic\Common\TransactionManagerInterface;
+use App\Logic\Essen\Event\MahlzeitAdoptedEvent;
+use App\Logic\Essen\Exception\MahlzeitNotFoundException;
+use App\Logic\Essen\Manager\MahlzeitManagerInterface;
+use App\Logic\Essen\Mapping\MahlzeitFactory;
+use App\Logic\Essen\Model\Mahlzeit;
+use App\Logic\Essen\Model\MahlzeitStatus;
+use App\Logic\Essen\Model\Wochentag;
+use App\Logic\Essen\UseCase\MahlzeitAdoptUseCase;
+use PHPUnit\Framework\TestCase;
+
+final class MahlzeitAdoptUseCaseTest extends TestCase
+{
+    private function tx(): TransactionManagerInterface
+    {
+        $tx = $this->createStub(TransactionManagerInterface::class);
+        $tx->method('execute')->willReturnCallback(static fn (\Closure $work): mixed => $work());
+        return $tx;
+    }
+
+    private function clock(): ClockInterface
+    {
+        $clock = $this->createStub(ClockInterface::class);
+        $clock->method('now')->willReturn(new \DateTimeImmutable('2026-09-18 12:00:00'));
+        return $clock;
+    }
+
+    public function testExecuteKopiertQuelleAlsNeuenGeplantEintrag(): void
+    {
+        $jetzt = new \DateTimeImmutable('2026-09-18 12:00:00');
+        $quelle = new Mahlzeit(7, 'Bolognese', 'mit Parmesan', [Wochentag::Mo], 3, MahlzeitStatus::Gegessen, $jetzt, $jetzt, $jetzt);
+
+        $manager = $this->createMock(MahlzeitManagerInterface::class);
+        $manager->expects(self::once())->method('find')->with(7)->willReturn($quelle);
+        $manager->expects(self::once())->method('create')->willReturnCallback(function (Mahlzeit $m) {
+            // Neue, geplante Kopie: gleiche Inhalte, aber ohne gegessenAm und ohne ID.
+            self::assertSame('Bolognese', $m->name);
+            self::assertSame('mit Parmesan', $m->notiz);
+            self::assertSame([Wochentag::Mo], $m->wochentage);
+            self::assertSame(MahlzeitStatus::Geplant, $m->status);
+            self::assertNull($m->gegessenAm);
+            self::assertSame(0, $m->sortOrder);
+            self::assertSame(0, $m->id);
+            // Persistenz vergibt die neue ID.
+            return $m->mitId(42);
+        });
+
+        $events = $this->createMock(EventDispatcherInterface::class);
+        $events->expects(self::once())->method('dispatch')->with(
+            self::equalTo(new MahlzeitAdoptedEvent(id: 42, name: 'Bolognese', quellId: 7)),
+        );
+
+        $useCase = new MahlzeitAdoptUseCase($this->tx(), $manager, new MahlzeitFactory(), $events, $this->clock());
+
+        $response = $useCase->execute(7);
+
+        self::assertSame(42, $response->id);
+        self::assertSame('Bolognese', $response->name);
+        self::assertSame(MahlzeitStatus::Geplant, $response->status);
+        self::assertNull($response->gegessenAm);
+    }
+
+    public function testExecuteUnbekannteQuelleWirft404UndLegtNichtsAn(): void
+    {
+        $manager = $this->createMock(MahlzeitManagerInterface::class);
+        $manager->method('find')->willThrowException(new MahlzeitNotFoundException(99));
+        $manager->expects(self::never())->method('create');
+
+        $events = $this->createMock(EventDispatcherInterface::class);
+        $events->expects(self::never())->method('dispatch');
+
+        $useCase = new MahlzeitAdoptUseCase($this->tx(), $manager, new MahlzeitFactory(), $events, $this->clock());
+
+        $this->expectException(MahlzeitNotFoundException::class);
+
+        try {
+            $useCase->execute(99);
+        } finally {
+            // Erwartete Exception oben.
+        }
+    }
+}
@@ -0,0 +1,107 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Tests\Unit\Logic\Essen\UseCase;
+
+use App\Logic\Common\EventDispatcherInterface;
+use App\Logic\Common\TransactionManagerInterface;
+use App\Logic\Essen\Dto\MahlzeitReorderRequest;
+use App\Logic\Essen\Event\MahlzeitReorderedEvent;
+use App\Logic\Essen\Exception\MahlzeitNotFoundException;
+use App\Logic\Essen\Manager\MahlzeitManagerInterface;
+use App\Logic\Essen\Model\Mahlzeit;
+use App\Logic\Essen\Model\MahlzeitStatus;
+use App\Logic\Essen\UseCase\MahlzeitReorderUseCase;
+use PHPUnit\Framework\TestCase;
+
+final class MahlzeitReorderUseCaseTest extends TestCase
+{
+    private function tx(): TransactionManagerInterface
+    {
+        $tx = $this->createStub(TransactionManagerInterface::class);
+        $tx->method('execute')->willReturnCallback(static fn (\Closure $work): mixed => $work());
+        return $tx;
+    }
+
+    private function mahlzeit(int $id, int $sortOrder): Mahlzeit
+    {
+        $jetzt = new \DateTimeImmutable('2026-09-18 12:00:00');
+        return new Mahlzeit($id, 'Gericht' . $id, '', [], $sortOrder, MahlzeitStatus::Geplant, $jetzt, $jetzt, null);
+    }
+
+    public function testExecuteRenommertSortOrderUndDispatchtEvent(): void
+    {
+        $manager = $this->createMock(MahlzeitManagerInterface::class);
+        $manager->method('find')->willReturnMap([
+            [2, $this->mahlzeit(2, 2)],
+            [1, $this->mahlzeit(1, 1)],
+            [3, $this->mahlzeit(3, 3)],
+        ]);
+
+        $gespeicherte = [];
+        $manager->expects(self::exactly(2))->method('update')->willReturnCallback(function (Mahlzeit $m) use (&$gespeicherte) {
+            $gespeicherte[$m->id] = $m->sortOrder;
+            return $m;
+        });
+
+        $events = $this->createMock(EventDispatcherInterface::class);
+        $events->expects(self::once())->method('dispatch')->with(
+            self::equalTo(new MahlzeitReorderedEvent([2, 1, 3])),
+        );
+
+        $useCase = new MahlzeitReorderUseCase($this->tx(), $manager, $events);
+        $useCase->execute(new MahlzeitReorderRequest([2, 1, 3]));
+
+        // id 2 → Position 1, id 1 → Position 2; id 3 (Position 3) bleibt unverändert.
+        self::assertSame([2 => 1, 1 => 2], $gespeicherte);
+    }
+
+    public function testExecuteSpruengtBereitsKorrektePosition(): void
+    {
+        $manager = $this->createMock(MahlzeitManagerInterface::class);
+        $manager->method('find')->willReturnMap([
+            [1, $this->mahlzeit(1, 1)],
+            [2, $this->mahlzeit(2, 2)],
+        ]);
+        $manager->expects(self::never())->method('update');
+
+        $events = $this->createMock(EventDispatcherInterface::class);
+        $events->expects(self::once())->method('dispatch');
+
+        $useCase = new MahlzeitReorderUseCase($this->tx(), $manager, $events);
+        $useCase->execute(new MahlzeitReorderRequest([1, 2]));
+    }
+
+    public function testExecuteLeereListeIstNoOp(): void
+    {
+        $manager = $this->createMock(MahlzeitManagerInterface::class);
+        $manager->expects(self::never())->method('find');
+        $manager->expects(self::never())->method('update');
+
+        $events = $this->createMock(EventDispatcherInterface::class);
+        $events->expects(self::never())->method('dispatch');
+
+        $useCase = new MahlzeitReorderUseCase($this->tx(), $manager, $events);
+        $useCase->execute(new MahlzeitReorderRequest([]));
+    }
+
+    public function testExecuteUnbekannteIdWirft404(): void
+    {
+        $manager = $this->createStub(MahlzeitManagerInterface::class);
+        $manager->method('find')->willThrowException(new MahlzeitNotFoundException(99));
+
+        $events = $this->createMock(EventDispatcherInterface::class);
+        $events->expects(self::never())->method('dispatch');
+
+        $useCase = new MahlzeitReorderUseCase($this->tx(), $manager, $events);
+
+        $this->expectException(MahlzeitNotFoundException::class);
+
+        try {
+            $useCase->execute(new MahlzeitReorderRequest([99]));
+        } finally {
+            // Erwartete Exception oben.
+        }
+    }
+}